Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block gallery: add support for image reordering #14768

Merged
merged 14 commits into from
May 20, 2019
Merged

Block gallery: add support for image reordering #14768

merged 14 commits into from
May 20, 2019

Commits on May 10, 2019

  1. Add move forward/backward mechanics

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    6b4528b View commit details
    Browse the repository at this point in the history

  2. Update selected image on move 

    so the visual hook stays the same.
    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    0b8e5d5 View commit details
    Browse the repository at this point in the history

  3. Set color when Forward/Bacward icons has focus

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    d853d62 View commit details
    Browse the repository at this point in the history

  4. Hide arrows behind phase_2 flag

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    c3c3996 View commit details
    Browse the repository at this point in the history

  5. Better UI

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    0c33360 View commit details
    Browse the repository at this point in the history

  6. Add disability conditions for forward/backward buttons

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    ff5e60d View commit details
    Browse the repository at this point in the history

  7. Use aria-disable instead of disabled 

    as to avoid focus loss when the control becomes disabled.
    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    5f36197 View commit details
    Browse the repository at this point in the history

  8. Remove PHASE_TWO check

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    6e7fe4c View commit details
    Browse the repository at this point in the history

  9. Dont bind event handler if images is first/last in sequence

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    5795530 View commit details
    Browse the repository at this point in the history

  10. Fix CSS after rebase

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    d0acb03 View commit details
    Browse the repository at this point in the history

  11. Fix JS from rebase

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    ed0e900 View commit details
    Browse the repository at this point in the history

  12. Disable buttons when the GalleryImage is not selected

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    c3db788 View commit details
    Browse the repository at this point in the history

  13. When remove button gets the focus the image is always selected

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    6d1fdbc View commit details
    Browse the repository at this point in the history

  14. Fix bleaking styles

    @oandregal
    oandregal committed May 10, 2019
    Configuration menu
    Copy the full SHA
    a3e5854 View commit details
    Browse the repository at this point in the history