Add more placeholders #1485
Merged
Add more placeholders #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Not sure if it's an issue with this branch, but I noticed a few issues with the text block now. The block boundary doesn't expand on single enter:
Also, it's only on text block deselect that a text placeholder appears, it doesn't appear just on double enter:
|
|
@jasmussen Can reproduce the first issue for a new post, but this seems to have been an issue for a while. The second one I can't reproduce. Placeholder shows fine on double enter... |
|
Alright I'll ticket the first one. Thanks. |
mtias
added
[Feature] Blocks
|
If there are no concerns, I'll merge this soon. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds placeholders to some blocks that don't currently have one, and formats them in the same way.
It also fixes a bug where styles would be messed up if there is no placeholder. To test that, make sure list and table works fine.