Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish step to preview with custom fields test #14894

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add publish step to preview with custom fields test #14894

merged 1 commit into from
Apr 10, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Apr 10, 2019

Description

As mentioned here - #14877 (comment) - the new preview end to end test I added should've included a publish step to properly reproduce #12617. This PR adds that publish step.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 10, 2019
@talldan talldan self-assigned this Apr 10, 2019
@talldan talldan mentioned this pull request Apr 10, 2019
Merged
5 tasks
gziolo
gziolo approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you and Travis on that :)

Let's get this in. It looks like a legit change.

@talldan talldan merged commit d1aad15 into master Apr 10, 2019
@talldan talldan deleted the update/preview-test branch April 10, 2019 10:26
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@talldan @mchowning
Add publish step to preview with custom fields test (WordPress#14894)
ab7f99a
@talldan talldan mentioned this pull request Apr 15, 2019
Merged
@aduth aduth mentioned this pull request Apr 15, 2019
Merged
aduth pushed a commit that referenced this pull request Apr 16, 2019
@talldan @aduth
Add publish step to preview with custom fields test (#14894)
ca583e1
aduth pushed a commit that referenced this pull request Apr 16, 2019
@talldan @aduth
Add publish step to preview with custom fields test (#14894)
c6fda90
This was referenced Apr 17, 2019
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@talldan talldan

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
5.5 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@talldan @gziolo @youknowriad