Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Try to clarify loading editor styles #14917

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Apr 10, 2019

Description

Attempt to add clarification to the loading of editor styles for themes

Clarify that the add_theme_support() is required in new editor which is new, and remove the wording around parsing for the add_editor_style

Types of changes

Documentation

@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Apr 10, 2019
@mkaz mkaz self-assigned this Apr 10, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful. Thanks for adding those explanations 👍

@mkaz mkaz merged commit 917338c into master Apr 11, 2019
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
@youknowriad youknowriad deleted the docs/12169/editor-styles branch April 12, 2019 11:06
mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
* Try to clarify loading editor styles

* Update wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants