Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoverImage: add text formatting. #1495

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented Jun 27, 2017

image

Fixes #1492

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jun 27, 2017
@mtias mtias requested a review from jasmussen June 27, 2017 11:38
@mtias
Copy link
Member Author

mtias commented Jun 27, 2017

@jasmussen tweaked the link-boundary background a bit in this context.

@jasmussen
Copy link
Contributor

Looks good! 👍 👍

@ellatrix
Copy link
Member

Not a big fan of limiting formatting options. Similarly, we do still show italic on quote style 2. I wonder if styling h* strong to font-weight: normal; would help. Similarly p em to font-style: normal; for the quote.

@mtias
Copy link
Member Author

mtias commented Jun 27, 2017

It'd be cool to try.

@mtias
Copy link
Member Author

mtias commented Jun 27, 2017

image

@iseulde let's try it on this one and if we like it we can extend to headings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants