-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end 2 end test dynamic allowed blocks #14992
Add end 2 end test dynamic allowed blocks #14992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed a different name for the lists of allowed blocks. It took me some time to understand why there are two arrays with 2 blocks where one of the constants says less than two :)
packages/e2e-tests/plugins/inner-blocks-allowed-blocks/index.js
Outdated
Show resolved
Hide resolved
packages/e2e-tests/plugins/inner-blocks-allowed-blocks/index.js
Outdated
Show resolved
Hide resolved
07ac66f
to
531ce2c
Compare
Co-Authored-By: jorgefilipecosta <jorge.costa@developer.pt>
Co-Authored-By: jorgefilipecosta <jorge.costa@developer.pt>
531ce2c
to
aaf962b
Compare
I see this test fail intermittently. Do you have any idea why that might be? I wonder if there might be some issue of race condition where the dynamic changes to the allowed blocks does not update synchronously. I sense this could happen based on how a lot of Otherwise, do you have any thoughts on how we could improve the stability of this test? Ideally it's something where we should be able to rely on these changes taking effect immediately, but at worst we could try to update the test to "wait for" some indication that it's been applied.
|
Description
This PR adds a simple end 2 end test that makes sure allowed blocks inside a parent block can be changed dynamically depending on some condition e.g: the number of child's the parent contains.
How has this been tested?
We just need to make sure the test cases pass.
Related: #14515