Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .git folder in unit test execution #14997

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

jorgefilipecosta
Copy link
Member

Description

Currently, test unit mechanism tried to find unit tests in the git folder. This PR fixes that problem.

How has this been tested?

Created a file randomstring.test.js in .git folder executed npm run test-unit and verified unit tests still pass.
Created a git branch update/myrandombranch.test.js executed npm run test-unit and verified unit tests still pass.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 16, 2019
test/unit/jest.config.js Outdated Show resolved Hide resolved
Co-Authored-By: jorgefilipecosta <jorge.costa@developer.pt>
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aduth aduth merged commit 89f8259 into master Apr 24, 2019
@aduth aduth deleted the fix/ignore-git-folder-in-unit-tests branch April 24, 2019 13:05
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants