Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Passing async functions to describe #14998

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Apr 16, 2019

Description

I'm getting the following errors on end 2 end test execution:

Returning a Promise from "describe" is not supported. Tests must be defined synchronously.
Returning a value from "describe" will fail the test in a future version of Jest.

Watching the test cases there seems to be no reason for passing an async function to describe.

How has this been tested?

Checked the end 2 end tests execute without a warning related to passing async functions to describe.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 16, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing it. I think it started to be the thing when I merged PR which applied changes after npm audit fix. I had the same changes in one of the branches but it’s far from ready.

@jorgefilipecosta jorgefilipecosta merged commit b496ebc into master Apr 16, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/passing-async-functions-to-describe branch April 16, 2019 12:54
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants