Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: remove __unstablePositionedAtSelection #15035

Merged
merged 3 commits into from
May 1, 2019
Merged

Components: remove __unstablePositionedAtSelection #15035

merged 3 commits into from
May 1, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 18, 2019 •
edited
Loading

Description

#14938 follow-up.

  • Removes the use of __unstablePositionedAtSelection.
  • Fixes an issue where anchorRect is passed to a plain component.

How has this been tested?

Insert and image, ensure the toolbar is positioned correctly and repositions when you change the width or select a different image.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added [Package] Format library /packages/format-library Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Apr 24, 2019
aduth
aduth approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review notes should be addressed, but are general clean-up tasks.

packages/components/src/popover/index.js Outdated Show resolved Hide resolved
packages/dom/src/dom.js Show resolved Hide resolved
packages/block-editor/src/components/writing-flow/index.js Show resolved Hide resolved
@ellatrix ellatrix force-pushed the try/remove-position-at-selection branch from c0e134d to 6e0cb83 Compare May 1, 2019 10:52
@ellatrix
Copy link
Member Author

ellatrix commented May 1, 2019

Thanks!

@ellatrix ellatrix merged commit a9a3907 into master May 1, 2019
@ellatrix ellatrix deleted the try/remove-position-at-selection branch May 1, 2019 11:25
@ellatrix ellatrix mentioned this pull request May 1, 2019
Closed
@aduth aduth mentioned this pull request May 8, 2019
Merged
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@oandregal oandregal Awaiting requested review from oandregal

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Format library /packages/format-library
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @aduth @youknowriad