-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent block breadcrumb overlap with block movers for full/wide blocks #15112
Conversation
Yep, good solution. 👍 👍 I don't see the jumpiness that shows up in your GIFs on my end, though — which is good, that jumpiness is a little weird. Here's what I see. Master: This branch: Both of those are cool to me. I think we should keep thinking about what to do with these hover labels, separately. Do we need them? Do they become tooltips? (Think hovering an img with a title on the web.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks need to pass.
Thanks for the review! I'll merge in once that test is complete. I agree, it may be worth removing the block breadcrumbs entirely. I'm not convinced they're needed anymore.
Tha only shows up under a really specific circumstance: if you hover over the center-to-right area of a block, activate the block breadcrumb, and then move your mouse over to the left of the block to trigger the appearance of the block movers. 🙂 |
#14145 introduced a new left-side placement for the block breadcrumb. This worked great at first, but when #15022 reintroduced the block movers for wide and full blocks, we realized that the new breadcrumb location overlapped with the block movers.
This PR is a potential fix for the overlap: it moves the block breadcrumb down slightly for full/wide blocks when the block movers are visible. It bumps right up against the block content itself, but I don't think this should actually cause any issues.
Before:
After: