Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra bottom margin for nested lists. #15158

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Remove extra bottom margin for nested lists. #15158

merged 2 commits into from
Apr 25, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 24, 2019

Currently, lists that are two levels deep (or more) appear with some extra-tall bottom margins:

Screen Shot 2019-04-24 at 3 03 22 PM

In previous versions of Gutenberg, that extra margin did not exist (I checked against Version 5.5.0). I believe this was introduced via #14407. This PR adds a quick rule to clear out the bottom margin there:

Screen Shot 2019-04-24 at 3 03 32 PM

@kjellr kjellr added [Type] Regression Related to a regression in the latest release [Block] List Affects the List Block labels Apr 24, 2019
@kjellr kjellr requested a review from jasmussen April 24, 2019 19:18
@kjellr kjellr self-assigned this Apr 24, 2019
@kjellr kjellr changed the title Remove extra bottom margin for 2nd level lists. Remove extra bottom margin for nested lists. Apr 24, 2019
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodness me, yes, thank you for fixing this!

@kjellr kjellr merged commit 7fd6969 into master Apr 25, 2019
@kjellr kjellr deleted the fix/list-spacing branch April 25, 2019 13:21
@kjellr kjellr added this to the 5.6 (Gutenberg) milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants