-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a11y string properly localizable #15161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @swissspidy for helping us with this improvement!
I wanted to ask if it's possible to use _x()
instead of __()
to be able to send a more accurate context to the translators, letting them know that this string is intended to be used be the Screen Reader engine.
Something like:
_x( 'Heading block. Level %s. Empty.', 'Spoken out loud by the screen reader' )
In WordPress itself we usually use a |
That sounds great! Thank you 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on iOS and it works OK.
hey @Tug 👋 I updated the position of translator comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Make a11y string properly localizable * Remove extra . after the content * Add `accessibility text` to the translators comment * Fix the wrong parameter * Change the position of translator comments
Description
Fixes the non-localizable code introduced by #15144.
This is a friendly reminder to think about internationalization best practices :-)
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: