Make a11y string properly localizable #15161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
the
Internationalization (i18n)
5 tasks
etoledom
reviewed
Apr 25, 2019
There was a problem hiding this comment.
Thank you @swissspidy for helping us with this improvement!
I wanted to ask if it's possible to use _x() instead of __() to be able to send a more accurate context to the translators, letting them know that this string is intended to be used be the Screen Reader engine.
Something like:
_x( 'Heading block. Level %s. Empty.', 'Spoken out loud by the screen reader' )
|
In WordPress itself we usually use a |
That sounds great! Thank you 🙏 |
gziolo
added
the
Mobile App - i.e. Android or iOS
pinarol
approved these changes
Apr 25, 2019
Tug
reviewed
Apr 25, 2019
|
hey @Tug 👋 I updated the position of translator comments |
5 tasks
This was referenced Apr 29, 2019
hypest
pushed a commit
that referenced
this pull request
May 2, 2019
* Make a11y string properly localizable * Remove extra . after the content * Add `accessibility text` to the translators comment * Fix the wrong parameter * Change the position of translator comments
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the non-localizable code introduced by #15144.
This is a friendly reminder to think about internationalization best practices :-)
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: