Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update CONTRIBUTING docs #15187

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Apr 25, 2019

Description

This PR seeks to make it easier to discover developer related documentation explaining how to contribute. It essentially extracts more detailed sections from the top level CONTRIBUTING.md file to their own files. The side effect of this change is that they will be also exposed in Gutenberg Handbook in addition to GitHub repository.

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Type] Developer Documentation Documentation for developers labels Apr 25, 2019
@gziolo gziolo self-assigned this Apr 25, 2019
@gziolo gziolo requested a review from draganescu April 25, 2019 16:01
@gziolo gziolo requested a review from aduth April 25, 2019 16:15
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a step in the right direction for updating the contributing documentation structure. In the current file the length itself is a problem. where stopping at a certain point would require a lot of "scanning" to get back in the flow.

With this new structure two things are achieved:

  1. There is an easier way to follow instructions and read through them
  2. The information is easier to refer to, packed in individual smaller bits

@gziolo gziolo merged commit e6fc9c4 into master Apr 26, 2019
@gziolo gziolo deleted the update/contributing-docs branch April 26, 2019 15:17
@gziolo
Copy link
Member Author

gziolo commented Apr 26, 2019

@draganescu - thank you for confirming that this is the change in the right direction. I appreciate your input 👍

@gziolo gziolo added this to the 5.6 (Gutenberg) milestone Apr 26, 2019
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements here. 👍 I also think by moving the bulk of the developer-oriented documentation out of CONTRIBUTING.md, we can more easily introduce tips for a variety of contribution types (already design and documentation) as being of equal emphasis.

* [Coding Guidelines](/docs/contributors/coding-guidelines.md) outline additional patterns and conventions used in the Gutenberg project.
* [Gutenberg Block Grammar](/docs/contributors/grammar.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it was intentional, but I like the reordering to have the more advanced topics arranged further down the list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my idea was to put at the top the most useful documents in the context of new contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants