-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Update CONTRIBUTING docs #15187
Conversation
82f5efa
to
b59c336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a step in the right direction for updating the contributing documentation structure. In the current file the length itself is a problem. where stopping at a certain point would require a lot of "scanning" to get back in the flow.
With this new structure two things are achieved:
- There is an easier way to follow instructions and read through them
- The information is easier to refer to, packed in individual smaller bits
@draganescu - thank you for confirming that this is the change in the right direction. I appreciate your input 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements here. 👍 I also think by moving the bulk of the developer-oriented documentation out of CONTRIBUTING.md
, we can more easily introduce tips for a variety of contribution types (already design and documentation) as being of equal emphasis.
* [Coding Guidelines](/docs/contributors/coding-guidelines.md) outline additional patterns and conventions used in the Gutenberg project. | ||
* [Gutenberg Block Grammar](/docs/contributors/grammar.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it was intentional, but I like the reordering to have the more advanced topics arranged further down the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my idea was to put at the top the most useful documents in the context of new contributions.
Description
This PR seeks to make it easier to discover developer related documentation explaining how to contribute. It essentially extracts more detailed sections from the top level
CONTRIBUTING.md
file to their own files. The side effect of this change is that they will be also exposed in Gutenberg Handbook in addition to GitHub repository.