Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Rename UnstableRichTextInputEvent to convention #15198

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 25, 2019

Related: #14239
Helps unblock: #15197

This pull request seeks to rename the UnstableRichTextInputEvent from @wordpress/block-editor to align to the convention of "Unstable & Experimental APIs" (i.e. renames to __unstableRichTextInputEvent).

An experimental or unstable function or object should be prefixed respectively using __experimental or __unstable.

https://github.com/WordPress/gutenberg/blob/master/docs/contributors/coding-guidelines.md#experimental-and-unstable-apis

Testing Instructions:

Verify there are no lingering references to the previous name.

Verify there is no impact on application runtime.

@aduth aduth added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Apr 25, 2019
@aduth aduth requested review from Tug and ellatrix April 25, 2019 19:48
@aduth aduth requested a review from gziolo as a code owner April 25, 2019 21:12
@aduth aduth merged commit 87d7fe4 into master Apr 26, 2019
@aduth aduth deleted the update/rename-unstable-rich-text-input-event branch April 26, 2019 18:53
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants