-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Tooling: Increase number of Travis E2E test jobs #15228
Conversation
Evaluating the result, it's an improvement, though not to the extent I might have hoped. Comparing:
The longest job decreases from 12m55s to 10m3s (22% decrease). The likely explanation here is that we'll encounter diminishing returns on the basis there is a common overhead amongst all these jobs: That all being said, an improvement is an improvement, and I still think it'd be worthwhile to move forward with this change. |
We also should look into how to optimize for Travis the usage of It might have a large impact on the duration of each job as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a go and see how it works in action. As noted, we should also look into other optimizations in parallel.
That's a good point. I'd mentioned something similar before in my "aside" of #14245 (comment). I'll make a note of this in the parent issue #15159. |
Related: #15159, #14289 (comment)
This pull request seeks to double the number of Travis jobs dedicated to running end-to-end tests. In other words, it distributes the number of tests across 4 containers (vs. 2 previously) for each of the "Admin with plugins" and "Author without plugins" variations.
The desired effect here is that the total duration of a build decreases, since the number of end-to-end tests handled by any one Travis container will have lessened by a half.
To the potential question of whether "more containers" is okay or not, see also #14289 (comment) .
Testing Instructions:
Verify that the build passes.