-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Include stylesheet in usage instructions. #15241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a great idea to add this note. I'm wondering whether we should add a similar note to all packages which also ship styles like block-library
or format-library
.
There is an unrelated issue with e2e test: https://travis-ci.com/WordPress/gutenberg/jobs/196208309#L1161
It's an interminient failure and I'm documenting it only so I could reference it in a follow-up PR where I will disable it. |
I think that's a good idea, I opened #15253 to track that. |
Without these it's easy to think something is broken, or that you're doing something wrong, until you realize that it's just that the missing CSS. Documenting this will save time and frustrating.