Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting Parent Blocks: Try clickthrough #15537

Merged
merged 11 commits into from
Jun 6, 2019
Merged

Selecting Parent Blocks: Try clickthrough #15537

merged 11 commits into from
Jun 6, 2019

Commits on Jun 6, 2019

  1. Selecting parents: Try clickthrough. 

    Clickthrough has you select the parent before you can select the child. This is already in place on the mobile breakpoints, this just expands it to desktop as well.

It is a work in progress, right now it is not working as intended: once you have "unlocked" the deepest level, it becomes immediately locked and you have to click through the layers again to unlock it again. The deepest layer should always be unlocked until you deselect all blocks again.
    @gziolo
    Joen Asmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    47d6de7 View commit details
    Browse the repository at this point in the history

  2. Render overlay on top of inner block only when none of the nested blo… 

    …cks is selected
    @gziolo
    gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    2667575 View commit details
    Browse the repository at this point in the history

  3. Fix overlay, fix breadcrumb, polish.

    @gziolo
    Joen Asmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    b66cb2d View commit details
    Browse the repository at this point in the history

  4. Remove click-overlay.

    @jasmussen @gziolo
    jasmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    74920ee View commit details
    Browse the repository at this point in the history

  5. Fix the selection of inner blocks for reusable blocks template

    @gziolo
    gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    e5a0b12 View commit details
    Browse the repository at this point in the history

  6. Disable async mode for parent blocks when nested block selected

    @gziolo
    gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    fafcb1f View commit details
    Browse the repository at this point in the history

  7. Refactor BlockListBlock to use AsyncModeProvider

    @gziolo
    gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    0f5ffac View commit details
    Browse the repository at this point in the history

  8. Make the reusable blocks save button clickable. i 

    At least this means you can edit and save reusable blocks.
    @jasmussen @gziolo
    jasmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    5c28d4b View commit details
    Browse the repository at this point in the history

  9. Fix so reusable blocks with nesting are editable.

    @jasmussen @gziolo
    jasmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    de050d4 View commit details
    Browse the repository at this point in the history

  10. Fix movers. 

    The z-index was too low. It had to be higher to accommodate the other z-index changes.
    @jasmussen @gziolo
    jasmussen authored and gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    b4b3e76 View commit details
    Browse the repository at this point in the history

  11. Bring the behavior closer to what we have as of today

    @gziolo
    gziolo committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    b0649e1 View commit details
    Browse the repository at this point in the history