-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color options to heading block. #15625
Conversation
e81c6b9
to
6e916e3
Compare
Do we have a decision here, because I'd rather not introduce something that is going to be removed (it's always hard to remove things when they become APIs) |
Yes, we're going to keep this in. A decision is made to keep background color on most (if not all) text blocks. #8171 (comment) Let's merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use an e2e test.
I wonder how much of this code could be reused across blocks.
Thank you for the reviews @youknowriad, @mapk 👍
I will follow up with an end 2 end test for this functionality.
We already have a big amount of code reusability, by using shared components for the UI, withColors for the logic, and shared functions. But I agree it is something we could try to improve further. The main decision we would need to do would be the way this reusability would work, the simplest option would be a supports flag for color, but in previous discussions, there was no clear agreement if we should continue investing in support options. |
This reverts commit 22ab406.
We really need this for all block controls (lists, paragraphs etc). Anything that can be used on a group block with a coloured background could cause readability issues and so the text colour will need to be changeable. |
That's the next step here, @BinaryMoon. We want to add text color options to all text blocks. |
The |
Heading background color was removed: With the thought that "The idea being that backgrounds should be higher-level (group block)." |
Description
Closes: #6012
This PR adds the color options available in the Paragraph and button block to the heading block.
How has this been tested?
I verified the color options in the heading block work as expected.