Backport WordPress 5.2.1 fixes #15650

youknowriad · 2019-05-15T11:46:28Z

https://github.com/WordPress/gutenberg/issues?q=label%3A%22Backport+to+WP+Core%22+is%3Aclosed

…ckage (#15528)

* Rich Text: Set applied format as active in applyFormats * Rich Text: Update toggleFormat tests per activeFormats revision * Rich Text: Replace existing active format in applied * Rich Text: Remove active format in all cases for removeFormat * Rich Text: Update toggleFormat tests per removeFormats revision * Testing: Update E2E test case to verify link display regression * Rich Text: Verify by test of activeFormats format replacement

ellatrix · 2019-05-15T13:42:10Z

I think everything is added now.

ellatrix · 2019-05-15T13:42:41Z

Let's see if the tests pass.

aduth · 2019-05-15T21:19:54Z

A recurring error I see in the failing build is this one:

TypeError: Cannot read property 'isContentEditable' of undefined

I can reproduce it as well, when trying to ArrowUp / ArrowDown between two paragraphs.

There are changes to both writing-flow/index.js and dom.js which are prime candidates for being culprit to these errors, though the specific changes don't immediately strike me as problematic.

aduth · 2019-05-16T00:27:01Z

A recurring error I see in the failing build is this one:

TypeError: Cannot read property 'isContentEditable' of undefined

This error is because we should have kept the target argument being passed to computeCaretRect in the cherry-picked 4e45835 . In master, this was later removed in a9a3907 , but since that change is not reflected here, I think we should keep the argument. The other option is to cherry-pick a9a3907 as well, or at least the relevant logic changes for computeCaretRect.

In 72539b8, I chose to simply reintroduce the target argument. This could be squashed/fixup'd into 4e45835.

aduth · 2019-05-16T00:54:09Z

There's a build failure caused by the console warnings tracked at Trac#47183 and fixed in master at #15502 . The changes in that pull request affect only tests, and should be safe to pull in here. I'll cherry-pick the merge commit 17c3571 to allow the build to pass.

* Testing: Skip test failures for font decoding warnings * Testing: Fix Classic block Add Media toolbar button click

ellatrix · 2019-05-16T07:46:52Z

packages/block-editor/README.md

@@ -483,5 +483,4 @@ Undocumented declaration.

 <!-- END TOKEN(Autogenerated API docs) -->

-


I've seen this around locally as well sometimes. Why does this happen?

This is probably related #15626 I'm investigating it.

#15679 should fix it.

No I actually had to add empty lines to the previous npm release (because of the failure we had) to force learna to detect these as changed. This just reverts those unnecessary changes.

No I actually had to add empty lines to the previous npm release (because of the failure we had) to force learna to detect these as changed. This just reverts those unnecessary changes.

Can someone clarify for me: Do these changes matter? Is there anything further which needs to be done in this branch for them?

No, nothing left to do here.

ellatrix · 2019-05-16T07:50:12Z

Thanks for looking at the test failures, @aduth! I seems there are still two left involving metaboxes.

youknowriad · 2019-05-16T08:29:37Z

The failure seems related to autop. It seems that the "p" tag is not added in the TinyMCE metabox.
That said, it happens only when we install popular plugins and the same test pass without these plugins.

I wonder if it's fine to just ignore this failure?

aduth · 2019-05-16T15:05:03Z

I've tracked the build failure to Advanced Custom Fields, specifically these two lines:

https://github.com/AdvancedCustomFields/acf/blob/079c93e029457eacbe91cc8508aa4b81fbc4777d/assets/js/acf-input.js#L12403-L12404

It's not clear to me yet why (a) this fails specifically on this branch and not others and (b) why or if ACF should be mutating the wp.editor global in this way.

cc @elliotcondon

Worth highlighting that the field being used in the test is not one intended to be managed by ACF, but rather its own custom metabox field:

https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/plugins/wp-editor-metabox.php
https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/specs/plugins/wp-editor-meta-box.test.js

aduth · 2019-05-16T15:13:25Z

It's not clear to me yet why (a) this fails specifically on this branch and not others

In master, the specific test case was changed to be skipped due to intermittent failures, perhaps related to the same plugin incompatibility (though not necessarily so, since it was both intermittent, and with a different error message). The relevant pull request was #15211, tracked for reintroduction at #15538 .

I will cherry-pick the merge commit 93c5ad3 from #15211 to sync with expected behavior from master. This still means there is a legitimate failure to be addressed, though it is not specific to this branch.

…15211)

youknowriad · 2019-05-16T15:20:16Z

I'm going to test quickly the fixes cherry-picked here and see if everything works as expected.

aduth · 2019-05-16T15:24:43Z

Noting: We probably want to be dropping the commit f004741 before merging. It was included to force Travis to run the tests. Then again, it wouldn't be a terrible thing to have the commit merged into the wp/5.2 branch.

aduth · 2019-05-16T15:27:15Z

I will cherry-pick the merge commit 93c5ad3 from #15211 to sync with expected behavior from master. This still means there is a legitimate failure to be addressed, though it is not specific to this branch.

To verify, I applied local changes to unskip the test in the master branch, and with POPULAR_PLUGINS flag, an identical error was produced when running the end-to-end test case.

youknowriad · 2019-05-16T15:28:27Z

Can't approve my own PR. I tested everything (except the google doc thing where it's hard to replicate). Everything seems to work as intended.

aduth · 2019-05-16T15:34:30Z

Relevant Trac ticket: https://core.trac.wordpress.org/ticket/47284

youknowriad and others added 4 commits May 15, 2019 12:26

Proxy the code/block-editor replaceBlock action in the core/editor pa…

1d09dde

…ckage (#15528)

Check for selection range count before calling getRangeAt (#15576)

730d791

Remove (non-special) comment nodes when pasting content (#15557)

705257d

youknowriad marked this pull request as ready for review May 15, 2019 12:22

youknowriad requested review from aduth, ajitbohra, gziolo, jorgefilipecosta, nerrad, noisysocks, oandregal, notnownikki, ntwb, Soean and talldan as code owners May 15, 2019 12:22

ellatrix and others added 4 commits May 15, 2019 15:16

RichText: fix RTL keyboard interactions (#15496)

5cc5660

Temporarily enable tests

f004741

RichText: show boundary only with editable element focus (#15466)

9ea31a7

Input Interaction: always reset initial vertical position rect (#15624)

4e45835

Block Editor: Restore WritingFlow computeCaretRect target argument

72539b8

Testing: Skip test failures for font decoding warnings (#15502)

c8dc17d

* Testing: Skip test failures for font decoding warnings * Testing: Fix Classic block Add Media toolbar button click

ellatrix reviewed May 16, 2019

View reviewed changes

Tests: Disable randomly failing e2e tests making Travis unreliable (#…

09359e3

…15211)

aduth approved these changes May 16, 2019

View reviewed changes

youknowriad merged commit e28b0d8 into wp/5.2 May 16, 2019

youknowriad deleted the backport/wp-5.2.1-fixes branch May 16, 2019 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport WordPress 5.2.1 fixes #15650

Backport WordPress 5.2.1 fixes #15650

youknowriad commented May 15, 2019

ellatrix commented May 15, 2019

ellatrix commented May 15, 2019

aduth commented May 15, 2019

aduth commented May 16, 2019 •

edited

Loading

aduth commented May 16, 2019

ellatrix May 16, 2019

oandregal May 16, 2019 •

edited

Loading

oandregal May 16, 2019

youknowriad May 16, 2019

aduth May 16, 2019

youknowriad May 16, 2019

ellatrix commented May 16, 2019

youknowriad commented May 16, 2019

aduth commented May 16, 2019

aduth commented May 16, 2019 •

edited

Loading

youknowriad commented May 16, 2019

aduth commented May 16, 2019

aduth commented May 16, 2019

youknowriad commented May 16, 2019

aduth commented May 16, 2019

		@@ -483,5 +483,4 @@ Undocumented declaration.

		<!-- END TOKEN(Autogenerated API docs) -->

Backport WordPress 5.2.1 fixes #15650

Backport WordPress 5.2.1 fixes #15650

Conversation

youknowriad commented May 15, 2019

ellatrix commented May 15, 2019

ellatrix commented May 15, 2019

aduth commented May 15, 2019

aduth commented May 16, 2019 • edited Loading

aduth commented May 16, 2019

ellatrix May 16, 2019

Choose a reason for hiding this comment

oandregal May 16, 2019 • edited Loading

Choose a reason for hiding this comment

oandregal May 16, 2019

Choose a reason for hiding this comment

youknowriad May 16, 2019

Choose a reason for hiding this comment

aduth May 16, 2019

Choose a reason for hiding this comment

youknowriad May 16, 2019

Choose a reason for hiding this comment

ellatrix commented May 16, 2019

youknowriad commented May 16, 2019

aduth commented May 16, 2019

aduth commented May 16, 2019 • edited Loading

youknowriad commented May 16, 2019

aduth commented May 16, 2019

aduth commented May 16, 2019

youknowriad commented May 16, 2019

aduth commented May 16, 2019

aduth commented May 16, 2019 •

edited

Loading

oandregal May 16, 2019 •

edited

Loading

aduth commented May 16, 2019 •

edited

Loading