-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of block names #1593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as the renaming goes this is 👍 from me, this makes much more sense than the smooshed together names. I'm not familiar yet with how pegjs works, so I wont mark this as approved, just because I don't yet know enough to properly review that part. |
That's fine, that's a separate PR anyway (#1152). |
4 tasks
`core-embed-youtube.html` could be a fixture file for `core/embed` or `core-embed/youtube`, for example. To resolve this ambiguity, try the more specific block name first.
This reverts commit 6c60313d6e0129a3022c79929d00c557772e4900. Conflicts: blocks/test/full-content.js
nylen
force-pushed
the
update/improve-block-names
branch
from
June 30, 2017 03:07
cab018b
to
c140f30
Compare
Merging to get this breaking change in sooner rather than later. |
mtias
added
[Feature] Block API
API that allows to express the block paradigm.
[Feature] Blocks
Overall functionality of blocks
[Feature] Parsing
Related to efforts to improving the parsing of a string of data and converting it into a different f
labels
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block API
API that allows to express the block paradigm.
[Feature] Blocks
Overall functionality of blocks
[Feature] Parsing
Related to efforts to improving the parsing of a string of data and converting it into a different f
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few blocks that have sub-optimal names due to our server-side parsing not handling dashes properly:
core/latestposts
should becore/latest-posts
core/embedcollegehumor
(and other embed blocks) should becore/embed-collegehumor
orcore-embed/collegehumor
. Per Slack discussion with @mtias, and because there are enough of these blocks that it makes sense for them to live in their own "namespace", I've gone with the latter.With the new PHP parser in #1152 we can resolve this ambiguity, with plenty of test cases, and set good standards for other block implementers.