Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix incorrect prop documentation for components/date-time #16073

Merged
merged 1 commit into from
Jun 11, 2019
Merged

[docs] fix incorrect prop documentation for components/date-time #16073

merged 1 commit into from
Jun 11, 2019

Conversation

dsifford
Copy link
Contributor

closes #16057

Let me know if you have any further questions/comments.

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Jun 10, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that currently, the code does not work if onChange is not set. I confirmed that for other input components onChange is required, so I guess this PR is consistent with the other components 👍

Thank you for your contribution!

@jorgefilipecosta jorgefilipecosta merged commit 164bc75 into WordPress:master Jun 11, 2019
@github-actions github-actions bot added this to the Gutenberg 5.10 milestone Jun 11, 2019
@dsifford dsifford deleted the dsifford-docs-components-date-time branch June 11, 2019 21:39
@gziolo gziolo modified the milestones: Gutenberg 5.10, Gutenberg 6.0 Jun 12, 2019
This was referenced Jul 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 6.0
Development

Successfully merging this pull request may close these issues.

DatePicker, TimePicker, and DateTimePicker incorrectly states onChange is optional
3 participants
@dsifford @jorgefilipecosta @gziolo