[RNMobile] Fix pasting text on Post Title #16116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
1 task
|
Thank you! |
daniloercoli
added a commit
that referenced
this pull request
Jun 14, 2019
…rnmobile/open-video-by-browser-for-android * 'master' of https://github.com/WordPress/gutenberg: (34 commits) [RNMobile] Native mobile release v1.7.0 (#16156) Scripts: Document and simplify changing file entry and output of build scripts (#15982) Block library: Refactor Heading block to use class names for text align (#16035) Make calendar block resilient against editor module not being present (#16161) Bump plugin version to 5.9.1 Editor: Fix the issue where statics for deprecated components were not hoisted (#16152) Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166) Scripts: Fix naming conventions for function containing CLI keyword (#16091) Add native support for Inserter (Ported from gutenberg-mobile) (#16114) docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144) docs(components/with-focus-return): fix typo in README.md (#16143) docs(block-editor/components/inspector-controls): fix image path in README.md (#16145) Add mention of on Figma to CONTRIBUTING.md (#16140) Bring greater consistency to placeholder text for media blocks. (#16135) Add descriptive text and a link to embed documentation in embed blocks (#16101) Update toolbar-text.png (#16102) Updating changelogs for the Gutenberg 5.9 packages release chore(release): publish [RNMobile] Fix pasting text on Post Title (#16116) Bump plugin version to 5.9.0 ... # Conflicts: # packages/block-library/src/video/video-player.android.js
I think the best would be to not use RichText on PostTitle, but let's have this discussion on another ticket. Eventually, the title should become a block (in case that impacts your thinking here). See #11553. |
|
Tested all sorts of pasting of single-line content into the title field in the mobile block editor using WPAndroid alpha-177 (12.8 alpha) on Pixel 3 Android 9 and it worked as expected. Also checked that I could undo changes and undo worked well (which I found helpful!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes wordpress-mobile/gutenberg-mobile#1099
This PR fixes an issue where pasting text on post title was behaving as pressing Enter key when the title field is empty.
Pasting send an event to
onReplace, that was wired directly toonEnterPress.This PR fixes the issue by adding an
onEnterprop toRichText, adding the ability to handle custom onEnter handling when needed.This PR does NOT fix pasting multi-paragraph text. I investigated multi-paragraph pasting and it will take some effort and discussion. I think the best would be to not use RichText on PostTitle, but let's have this discussion on another ticket.
gutenberg-mobileside PR: wordpress-mobile/gutenberg-mobile#1123To test: