Update/16128 add attribute types documentation #16220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added valid inputs to the type field in attributions on block-attributes.md
AdamDTak2112
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
notnownikki and
youknowriad
as code owners
mkaz
approved these changes
Jun 19, 2019
docs/designers-developers/developers/block-api/block-attributes.md
Outdated
Show resolved
Hide resolved
chrisvanpatten
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Just adding a block on the PR until this change (a combo of mine + @mkaz's changes) is merged in, then I'd love to see this landed. Thanks!
See [WordPress's REST API documentation](https://developer.wordpress.org/rest-api/extending-the-rest-api/schema/) for additional details.
…s.md Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
I was advised by the core contributors to either add a definition for number, or delete the definition for integer. After noting that a definition of number (either an integer or floating point number) could create more confusion, I opted for the latter choice.
…s.md Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
|
I've taken the suggestions from @mkaz and @chrisvanpatten. I committed the changes, and please let me know if there is anything else that needs to be changed. Thank you so much for letting me contribute to this! I promise I'll capitalize the P from now on :) |
chrisvanpatten
approved these changes
Jun 19, 2019
|
Thanks for the changes and welcome as a new Gutenberg contributor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16128 . Added accepted attribute types for the Blocks API, including a link to the Wordpress REST API documentation for clarification.
How has this been tested?
Ran changes in docs through Visual Studio Code's markdown preview testing.
Changes should not affect any other code, as it was purely an addition to documentation. No existing documentation was altered.
Screenshots
Types of changes
Only a change in documentation, as clarification was requested through #16128 .
Checklist: