Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native component HTMLTextInput #16226

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 19, 2019

Description

This is step 7 of wordpress-mobile/gutenberg-mobile#958
It ports the HTMLTextInput component from gutenberg-mobile to gutenberg. For reference this component is a simple HTML text editor for mobile native.

How has this been tested?

Tested with GB mobile PR wordpress-mobile/gutenberg-mobile#1162

Types of changes

Adding native only component: an html editor

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Sorry, something went wrong.

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 19, 2019
@Tug Tug added this to the Future milestone Jun 19, 2019
@Tug Tug self-assigned this Jun 19, 2019
@Tug Tug force-pushed the rnmobile/add/html-text-input-component branch from aee520e to d1bd3b5 Compare June 20, 2019 07:36
@Tug Tug marked this pull request as ready for review June 20, 2019 09:11
Tug added 2 commits June 20, 2019 11:15

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Tug Tug requested review from SergioEstevao, etoledom and hypest June 21, 2019 06:49
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tug
Copy link
Contributor Author

Tug commented Jun 21, 2019

Thanks for the review @etoledom 🎉

@Tug Tug merged commit 705d744 into master Jun 21, 2019
@Tug Tug deleted the rnmobile/add/html-text-input-component branch June 21, 2019 09:04
@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.0 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants