Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Editor and Layout in @wordpress/edit-post (Ported from Gutenberg Mobile) #16260

Merged
merged 3 commits into from
Jun 26, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 24, 2019

Description

This is step 8b of wordpress-mobile/gutenberg-mobile#958
This PR ports the gutenberg-mobile AppContainer and MainScreen to gutenberg as the Editor and Layout components inside @wordpress/edit-post.
This is not needed to implement Inner blocks for mobile native but is a nice improvement which will help port the remaining of our code to gutenberg.

How has this been tested?

GB Mobile PR wordpress-mobile/gutenberg-mobile#1171

Types of changes

Adds native support for Editor and Layout

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 24, 2019
@Tug Tug added this to the Future milestone Jun 24, 2019
@Tug Tug self-assigned this Jun 24, 2019
@Tug Tug added the [Status] In Progress Tracking issues with work in progress label Jun 24, 2019
@Tug Tug requested review from SergioEstevao, hypest and etoledom June 25, 2019 08:44
@Tug Tug removed the [Status] In Progress Tracking issues with work in progress label Jun 25, 2019
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉

Tested via wordpress-mobile/gutenberg-mobile#1171 (review)

JS unit test are failing on CI, but they are passing locally.
Maybe retrying will help!

@Tug Tug force-pushed the rnmobile/add/edit-post-editor branch from 67f82bb to 7249027 Compare June 26, 2019 11:30
@Tug
Copy link
Contributor Author

Tug commented Jun 26, 2019

@etoledom Thanks fo the review 🎉

JS unit test are failing on CI, but they are passing locally.

I rebased but they're failing on master as well

@Tug Tug merged commit b88bfc1 into master Jun 26, 2019
@Tug Tug deleted the rnmobile/add/edit-post-editor branch June 26, 2019 12:21
@hypest
Copy link
Contributor

hypest commented Jun 28, 2019

I think that the changes related to what happens on html/visual mode switch introduced a regression (Case A in wordpress-mobile/WordPress-Android#10092 (comment)).

Any context about why the mode change tries to send data to the the parent app? @Tug , can you elaborate about these lines? :

// refresh html content first
this.serializeToNativeAction();

@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.1 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants