Fixes Caption Loss with Gallery, saves captions using rest API #16340
Conversation
kadencewp
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
| body: data, | ||
| method: 'POST', | ||
| } ); | ||
| } |
There was a problem hiding this comment.
Why should we do so in the Gallery and not in the Image. I think the decision has been made in Gutenberg to not persist the caption into the Media Library because it's a confusing flow if you have the same image in multiple posts, but you want the caption to be different.
There was a problem hiding this comment.
Hey @youknowriad, when I worked on this and pushed this I wasn't aware of that decision, I was only trying to be helpful. I tried to read up on what others had posted about this and provide a possible solution that made sense to me. You can close this if you want.
Wherever that decision was made it seems to me like its a more confusion workflow with it not syncing with the media library. Especially when you edit the gallery and lose your captions. ¯_(ツ)_/¯
There was a problem hiding this comment.
yeah, I added the "Needs Design Feedback" to get some opinions. I highly appreciate your willingness to contribute. I'm hoping we could find some ways to improve the flows there.
|
This was discussed in #design today. While I could see a benefit to this PR, when users tend to use the same image multiple times, it seems this could cause more confusion for the end user. For example, I have an image that via the media library, I set a default caption for. When I add that media into a post and update the caption for that post, I'm next expecting the caption to be saved back to the media library. However, with a way to say, yes, update this caption back, then I'm good with it, but that seems to be overloading the front-end interface. |
|
Let's close this for now, and revisit later if needed. |
Description
This saves captions that are edited and written in Gutenberg for the gallery block.
Fixes: #8310
Related: #15004
How has this been tested?
Add a gallery with images, edit image captions. Check media library and captions are saved.
Screenshots
Types of changes
Uses debounce from Lodash to keep the calls to the rest API to a minimum.
Checklist: