Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Use strict comparisons #16381

Merged
merged 2 commits into from
Jul 2, 2019
Merged

PHPCS: Use strict comparisons #16381

merged 2 commits into from
Jul 2, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Jul 1, 2019 •
edited
Loading

Description

Rule: Unless absolutely necessary, loose comparisons should not be used, as their behaviour can be misleading.

  • Use strict comparisons === instead of ==.
  • Use in_array() with strict parameter

@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 1, 2019
@Soean Soean merged commit a84e941 into master Jul 2, 2019
@github-actions github-actions bot added this to the Gutenberg 6.1 milestone Jul 2, 2019
@Soean Soean deleted the update/code-for-phpcs branch July 2, 2019 07:44
@Soean Soean mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@aduth aduth Awaiting requested review from aduth

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Soean @swissspidy