Single TinyMCE: Add TinyMCE-unaware control registration APIs #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously relied on referencing from window global
Until we can arrange to fit all alignment options
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
Single TinyMCE: Add TinyMCE-unaware control registration APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to introduce new APIs for registering controls, enabling them to specify behaviors for
onClickandisActivewith matching implementations for current behavior.Testing instructions:
There should be no regressions from existing behavior. Changes include adding all alignment options to paragraphs and removing (temporarily) alignment options from headings (see 2e9476d extended description).