Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Install a block from inserter #16524
WIP: Install a block from inserter #16524
Changes from all commits
1060588
8fc202a
ebd1148
e85b2a0
7dbdf01
673475e
069d796
a02a3c7
7824941
e08184b
b5e1756
810546b
78e7883
e363149
c67d4f3
bdda0cc
acca61d
049297f
512b099
4b8e27a
a258146
9c2ab35
53e6e57
d6cae04
0e4c81b
97326c8
c2d142a
4ddf8c7
95bcc09
3745493
6633c6d
c1f7b11
5a225d8
9041d62
1d77f85
7774547
01c311b
b9baa64
37a0080
16dfdfe
5882bde
2b930f0
d017ac0
52987f9
038c141
14c6d74
56b20fe
b99c417
92ac7cd
52eb638
9be2347
b26dbda
953d3df
19a2de9
c643d55
6449373
75cc8d0
b563c43
6ed9aaa
22c7854
fae82f8
37444c5
46dbf23
d9b0db5
7a4fb2b
4444710
bff4995
ac54237
89e5862
20e0e79
b23ba87
7a39b70
b3bd752
b2352ff
8a9603b
2ec1a96
762a726
64ece6c
4b3d836
e4cc959
822bcc1
d91f669
1ddab6c
01be3e0
7021e2e
56a790a
5df0ffc
e25c6c6
0d137f3
fde3dca
c270540
3544494
ed1bcb5
36dd5a3
22f6a3d
df46fdc
e90876f
765571b
c0d1738
9113882
bc3f77e
d5f1db8
e37c23d
f65b493
d766d67
b265d93
78e4566
e0772d0
345a1db
5b0b5c9
7840221
4b3c898
2e7889f
649982d
e47e214
e3bc38c
bebbb23
dad8d44
c877957
d1f86f5
d1faced
f2bd345
d184693
d0d832a
711d908
3174112
1f4ad26
54a891c
2bab650
8bb30b1
4a9c324
d1687ad
11978b1
868cd14
3f5804e
15e0012
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't feel very "restful" to use different URLs for the create and delete actions. Could "installation" be a resource? e.g. so
POST /installations
creates andDELETE /installations/:id
deletes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this in a follow-up PR.