Fix issue where the toolbar can be hidden for the block after a wide aligned image #16530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
jorgefilipecosta
approved these changes
Jul 11, 2019
| ref.current.style.transform = `translate3d(${ newTransform.x }px,${ newTransform.y }px,0)`; | ||
| ref.current.style.transform = newTransform.x === 0 && newTransform.y === 0 ? | ||
| undefined : | ||
| `translate3d(${ newTransform.x }px,${ newTransform.y }px,0)`; |
There was a problem hiding this comment.
I wonder why applying a translate3d with all coordinates as 0 causes this problem, it seems unexpected. Supposedly translate3d(0,0,0) is a common "hack" to force hardware acceleration and makes CSS transitions smoother, but I did not expect a visual impact.
There was a problem hiding this comment.
Yes, I don't know it seems to mess up with z-index somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16519
Testing instructions