Visible focus and active styles for Windows high contrast mode #16554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
aduth,
ajitbohra,
chrisvanpatten,
ellatrix,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
tellthemachines
added
[a11y] Color Contrast
[Focus] Accessibility (a11y)
|
Thanks @tellthemachines ! Looks good from an accessibility perspective! |
tellthemachines
force-pushed
the
fix/visible-states-high-contrast
branch
from
702de4a
to
0e8c1f3
Compare
draganescu
approved these changes
Jul 29, 2019
|
+1 |
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Visible focus/active styles in high contrast mode. * Updated mixin call.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Visible focus/active styles in high contrast mode. * Updated mixin call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the negative
outline-offsets that were making outlines hard to see;Added focus outline for calendar buttons (the ones for navigating from month to month);
Added thin outline for color picker buttons to be visible;
Added thin dotted outlines for active states in toolbar. (Would appreciate design input on this - settled for dotted because a thin solid outline was hard to tell apart from the toolbar outline itself - see attached screenshots.)
How has this been tested?
Tested locally on Windows 10 set to high contrast mode, with Edge, IE and Firefox.
Used keyboard to tab through several blocks as well as the Block and Document sections of the sidebar.
Screenshots
Toolbar on Edge:
Toolbar on Firefox:
Toolbar on IE:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: