Update: Document and Remove experimental mark from URLPopover "subcomponents" #16566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer and URLPopover.LinkEditor.
jorgefilipecosta
requested review from
aduth,
ajitbohra,
daniloercoli,
ellatrix,
etoledom,
gziolo,
SergioEstevao,
Soean,
talldan and
youknowriad
as code owners
draganescu
approved these changes
Jul 29, 2019
|
I have also merged this so that it is available in master, since the components can be useful in the incoming navigation menu block. |
youknowriad
deleted the
update/document-link-edit-components-and-remove-experimental-mark
branch
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…wer and URLPopover.LinkEditor. (#16566)
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…wer and URLPopover.LinkEditor. (#16566)
aduth
reviewed
Dec 3, 2019
| } from '@wordpress/components'; | ||
| import { safeDecodeURI, filterURLForDisplay } from '@wordpress/url'; | ||
|
|
||
| function LinkViewerUrl( { url, urlLabel, className } ) { |
There was a problem hiding this comment.
Based on the file name, this probably should have been named LinkViewer. In any case, this specific naming doesn't adhere to capitalization guidelines, and it should at the very least be LinkViewerURL. Thankfully it doesn't seem to be part of the public API?
Edit: Oh, I see this file contains multiple components. In that case, I might have suggested each component get its own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #15570.
I'm not sure if these components should be "inside" URLPopover as they may be used outside. But I don't know a better place for them.
Exposing the components inside wp.components... seems to pollute the number of components we offer. These components use other components, they are not very useful, and it is easy to get their behavior using different components. The main reason they were created was to avoid code repetition.
They make it more straightforward to get a URLPopover with some UI. Otherwise, for each block where we want to add href functionality, we will need to repeat this code all the time. The reason to have them inside URLPopover is that the use case we have in mind for them is as children of that component and they were only tested in that context they may or may not work correctly when the parent is different.
How has this been tested?
I verified the link functionality in the image block toolbar still works as expected.
I verified the link format in the paragraph block still works as expected.