-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Add missing dependencies to package #16628
Block Editor: Add missing dependencies to package #16628
Conversation
Travis complains:
|
@swissspidy Any idea what I'm doing wrong? I've run both |
@@ -28,6 +28,7 @@ | |||
"@wordpress/blocks": "file:../blocks", | |||
"@wordpress/components": "file:../components", | |||
"@wordpress/compose": "file:../compose", | |||
"@wordpress/core-data": "^2.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block editor shouldn't depend on core-data we should instead refactor it to remove the need for this dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgefilipecosta do you know why we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get at least react-autosize-textarea
and traverse
bits in independently, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that block-editor should not depend on core-data, and I don't know the reason we have this dependency. Maybe we should just remove the import from: https://github.com/WordPress/gutenberg//blob/a3ef9605c74a8f3e6cb57a28fad33e4701585d6a/packages/block-editor/src/index.js#L5
In my tests, it seems to work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgefilipecosta can you help to remove it in another PR? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @simison, I'm sorry for the delay I had some AFK time. I added this issue to my to-do list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and way much more of issues :)
Description
I'm using
@wordpress/block-editor
as a dependency for a Jetpack PR, Automattic/jetpack#13070.During build, webpack complained about a number of missing dependencies, which seems warranted:
@wordpress/core-data
:gutenberg/packages/block-editor/src/index.js
Line 5 in e82b7c6
react-autosize-textarea
:gutenberg/packages/block-editor/src/components/block-list/block-html.js
Line 5 in 7964f38
traverse
:gutenberg/packages/block-editor/src/utils/transform-styles/traverse.js
Line 4 in e82b7c6
This PR is adding them to
block-editor
'spackage.json
How has this been tested?
(Doesn't really need testing since I'm just explicitly adding dependencies that were previously used implicitly.)
Types of changes
Bug fix
Checklist: