-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart block appender #16708
Merged
Merged
Smart block appender #16708
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a1d158b
if thre is only one there is only one
draganescu 1f5081b
made a new insertion point selector, some code review refactoring
draganescu 06d44c1
better handling of inserter
draganescu 05c1ebf
refactoring and named block insertion
draganescu 525385c
updates to the appender
draganescu 2e904e1
update snapshots
draganescu 4d89b0b
update docs
draganescu d80fc7f
default inserter label is used in so many tests
draganescu 55f3f95
fixed allowed blocks test
draganescu ec1eecc
snapshot updated
draganescu 07b652c
better naming and removed the need for es-lint disabling
draganescu ce0ec9d
improved the inserter label construction
draganescu 3bf7909
improved the doc of getTheOnlyAllowedItem selector
draganescu c977baf
reverting test patches becasue patching without understanding is bad,…
draganescu d2fda6e
moved getInsertionIndex out of selectos and back into each component …
draganescu 157097b
docs generated
draganescu 02edd01
added experimental labels to new selectors, added es-lint comment back
draganescu e451afd
updated docs
draganescu bb2bd63
Update packages/block-editor/src/store/selectors.js
draganescu 97dac6e
Update packages/block-editor/src/store/selectors.js
draganescu 134d182
refactored and fixed some coding errors
draganescu b2f709a
small code move
draganescu 1a40731
small code move
draganescu 7049dc4
removes aria attrs for autoinserted items
draganescu 9910348
fixes typo, adds translators comment
draganescu 4832f45
simplifies the intserter logic
draganescu 36de754
fix for the simplification
draganescu 3f0d68e
simplifies by using one selector and passing props in compose
draganescu e82ba8f
small code updates
draganescu 65a4b58
lint
draganescu a3d9ad6
renamed insertedBlock
draganescu 50b2637
small doc update
draganescu 488aa5c
adds tooltip to the default button appender
draganescu b2c27f6
refactores for more self documenting varnames
draganescu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this button with an icon and a tooltip is now looking exactly like an
IconButton
😄https://github.com/WordPress/gutenberg/blob/master/packages/components/src/icon-button/index.js