Deprecated: Output an informational message for deprecation when no version provided

[gziolo]

Description

When there is no options.version param provided deprecated method outputs more relaxed warning message to the Web Console.

The fact that we warn when there is no clear path for removing deprecation is very confusing in my opinion. The change proposed tries to make it less dramatic for 3rd party developers. The idea is that when there is no version provided we are going to support deprecated version forever according to Deprecations document. As soon as we decide to remove it, we should specify the target version for removal and it will automatically make the message stronger.

Before

After

[gziolo]

@aduth, should we add info to the list of observed console message types in e2e tests?

gutenberg/packages/e2e-tests/config/setup-test-framework.js

Lines 32 to 35 in 32b7b34

	const OBSERVED_CONSOLE_MESSAGE_TYPES = {
	warning: 'warn',
	error: 'error',
	};

We already cover it for unit tests through jest-console package:

gutenberg/packages/jest-console/src/supported-matchers.js

Lines 1 to 6 in 32b7b34

	const supportedMatchers = {
	error: 'toHaveErrored',
	info: 'toHaveInformed',
	log: 'toHaveLogged',
	warn: 'toHaveWarned',
	};

gutenberg/packages/jest-console/src/index.js

Line 48 in 32b7b34

forEach( supportedMatchers, setConsoleMethodSpy );

[aduth]

Hm, I like the updated string, but I feel like we should always warn when something is deprecated. It shouldn't be interpreted as advisory, it should be a motivator to move away from.

[draganescu]

I tend to agree with @aduth that deprecations should be a warning indifferent of version. It is one of the ways that pushes people to work on stuff they don't like, all these warnings, while informational messages are not motivating enough :)

Something to add is the word "version" to this string: "%feature% is deprecated and will be removed in version 11"

[gziolo]

@aduth and @draganescu - I changed back to console.warn to be used in all cases. I also added the version keyword in the message when appropriate.

[aduth]

Deprecated enhancements got me thinking: #16842

[gziolo]

Deprecated enhancements got me thinking: #16842

Yeah, very cool ideas 💯