Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edit gallery toolbar button #16778

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

jorgefilipecosta
Copy link
Member

Description

This PR follows the suggestion discussed on #16548 (comment) and removes the edit gallery button from the gallery block.

How has this been tested?

I created a gallery I added some images and I verified the edit gallery button does not appear on the block toolbar.

@jorgefilipecosta jorgefilipecosta added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media labels Jul 26, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally feel it's better because the way that button worked was confusing and now we can move, remove and add images without opening the media library (inline).

We might need a button in the image itself to edit one image (The last mockup here should be a good starting point #11952)

That said, let's have more thoughts here @karmatosed @mapk @mtias @kjellr

@kjellr
Copy link
Contributor

kjellr commented Jul 29, 2019

Interesting. As others noted in the previous thread, the main thing missing here is the ability to edit metadata for individual images. Maybe we should add in a control like this?

Frame 2

Anyway, as long as we have a plan for that, I think it's probably okay to remove this menu item.

(As an aside, I originally missed those move controls, so I opened a PR to help make them a little larger. Really though, I can't wait for drag & drop to happen for these — I imagine that'll be the primary way of rearranging galleries for many people.)

@mapk
Copy link
Contributor

mapk commented Aug 5, 2019

I'm trying to test this out, but it appears I no longer have a Gallery block. Am I gutenberging wrong?

gallery

@mapk
Copy link
Contributor

mapk commented Aug 5, 2019

Nevermind, I had the Gallery block hidden in the Block Manager. It's working as expected! Basically, I was definitely Gutenberging wrong.

@jorgefilipecosta
Copy link
Member Author

It's working as expected!

Hi @mapk, is that a green light :)?

@jorgefilipecosta jorgefilipecosta force-pushed the remove/edit-gallery-toolbar-button branch from 4e19d05 to bdece04 Compare August 8, 2019 18:01
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good to go! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants