-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try making the hover state of nested blocks more visible #16820
Conversation
This allows for us to match the existing hover color on hover.
I've adjusted the colors a little bit to make this a little smoother: Now, the all-around hover border color more closely matches the thick left border (and breadcrumb), which feels much more subtle and considered. In order to make this feel natural, I had to lighten the dashed border colors by a couple steps. This makes them a little less easier to see, but I think it still feels pretty solid overall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot, it's subtle enough to give me feedback but also feels not overwhelming. I do think testing this with some deep level nesting is important but getting it in seems sensible to me as a starting point.
This ensures that they apply correctly in a 3+ level deep scenario.
Thanks, @karmatosed! I've pushed a couple small fixes:
Mind giving this one more look? |
Yeah, I've seen that too. I think the block boundaries need to be fine-tuned a little bit, but that's probably a much more complicated problem. 😄 |
Works well for me with changes. I stand by we should iterate based on feedback of deeper nesting and I do also agree there is something weird going on about boundaries to fix in another issue. |
* Try using a solid border for the hover state of nested blocks. * Try using slightly lighter dashed borders. This allows for us to match the existing hover color on hover. * Add dark mode styles. * Expand hover styles to cover all children of a parent block. This ensures that they apply correctly in a 3+ level deep scenario.
* Try using a solid border for the hover state of nested blocks. * Try using slightly lighter dashed borders. This allows for us to match the existing hover color on hover. * Add dark mode styles. * Expand hover styles to cover all children of a parent block. This ensures that they apply correctly in a 3+ level deep scenario.
Following up from #14961.
Currently, when you hover over the new dashed borders for nested blocks, nothing happens:
In the original PR, we briefly discussed improving upon this by adopting a hover state. This PR implements a similar hover state to the one proposed there, but it uses a
border-style
change instead, which I think is a little more visible than jus the color change. Still could use some iteration though:Todo: