Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording and fix some typos in the release tool / docs #16832

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

swissspidy
Copy link
Member

Description

While performing today's release I encountered a few parts with typos etc. that I thought could be improved.

It started with a small typo in the suggested command in the release docs, and continued with some inconsistencies in the actual release tool.

How has this been tested?

I just updated some texts, no code changes involved.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for the fixes

'You can access the Github release here: ' + success( release.html_url ) + '\n',
'In a few seconds, you\'ll be able to update the plugin from the WordPress repository.\n',
'You can access the GitHub release here: ' + success( release.html_url ) + '\n',
'In a few minutes, you\'ll be able to update the plugin from the WordPress repository.\n',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants