Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Palette: add a purple / violet color option to the default color palette. #16833

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

mtias
Copy link
Member

@mtias mtias commented Jul 31, 2019

This should make the color spectrum a bit more complete.

image

@mtias mtias added the [Feature] UI Components Impacts or related to the UI component system label Jul 31, 2019
@mtias mtias force-pushed the update/default-color-palette branch from 069e428 to 0039be0 Compare July 31, 2019 11:23
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 Looks good!

@karmatosed
Copy link
Member

Yay! This is great.

@kjellr
Copy link
Contributor

kjellr commented Jul 31, 2019

This is an aside, but I was wondering if we should have white as one of our color options? This purple and our red color throw up a contrast warning when you first use them as backgrounds. This is easily fixed by using a white text color, but it's a little rough to have to go into the custom color picker to do that:

purple-white

I also find myself frequently wanting to set white text when in the Cover block for instance.

@mtias
Copy link
Member Author

mtias commented Aug 1, 2019

Agreed a white would be useful, also would be good to try a few more grays by default.

@karmatosed
Copy link
Member

karmatosed commented Aug 1, 2019

Agreed a white would be useful, also would be good to try a few more grays by default.

This is just an idea but what about on hovering over a color and there being a range of options in that color? The idea may be totally not a great one but my thinking is it stops having lots of colors showing by default, particularly if we're talking shades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants