Editor: Optimize common dependencies bail-out #16839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Performance
1 task
epiqueras
approved these changes
Jul 31, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #16402 (comment), #16402 (comment)
This pull request seeks to apply a minor optimization to the block sources behavior implemented in #16402 to avoid repeated validation of common data access within loops to sources and blocks applications. It's unlikely this has a significant impact, but these loops are both called for every change to a block in a post (e.g. each keypress).
Testing Instructions:
Repeat testing instructions from #16402.