-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing Flow: fix empty horizontal arrow nav #16846
Conversation
77f2236
to
f08ac7d
Compare
f08ac7d
to
9787d34
Compare
Rebased. This regression is important to be fixed ASAP I think. :) Some of it has been introduced by #16733. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this for the first time today, so it's great there's a fix ready! It worked well in my testing. I'm not completely familiar with the code or how isEdge
works, but when debugging I noticed the issue was with the position comparison returning false, so the fix seems good.
Thanks for the review @talldan! |
* Writing Flow: fix horizontal arrow nav * Add e2e test * Add inline comment
* Writing Flow: fix horizontal arrow nav * Add e2e test * Add inline comment
Description
Fixes #16841.
It seems like the cause of these regressions are:
Solution:
contenteditable=false
on the placeholder so that it never catches selection.How has this been tested?
See #16841.
Screenshots
Types of changes
Checklist: