fix all JSDoc eslint errors/warnings across the entire repository #16870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsifford
requested review from
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli,
dmsnell,
ellatrix,
etoledom,
gziolo,
jorgefilipecosta,
mkaz,
nerrad,
oandregal,
ntwb,
SergioEstevao,
Soean,
talldan and
youknowriad
as code owners
talldan
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
This looks good. We'd probably want to merge it as soon as possible to avoid conflicts.
I've avoided commenting on any doc formatting that was already incorrect. I only spotted a couple of things that might need some modification.
Looks like the build failed as there are some altered files after running the build, probably some docs that need to be generated using npm run docs:build.
gziolo
reviewed
Aug 2, 2019
gziolo
approved these changes
Aug 2, 2019
talldan
added
[Type] Code Quality
|
Fixes have been applied for the issues mentioned. I ran |
5 tasks
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…6870) * chore: fix all JSDoc eslint errors/warnings across the entire repository * fix: address code review comments
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
…6870) * chore: fix all JSDoc eslint errors/warnings across the entire repository * fix: address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #16869
Description
This PR simply fixes any eslint errors/warnings that arose as a result of switching to
eslint-plugin-jsdoc.How has this been tested?
ESlint runs and there are no longer any warnings associated with the changes to JSDoc-related lints.
Screenshots
N/A
Types of changes
Code quality
Checklist:
Note: This is my first cherry-picked PR so hopefully I didn't blow anything up!