Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownMenu: Fix shifting menu items #16871

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

noisysocks
Copy link
Member

Fix menu items in the More menu from shifting horizontally when selected. This was noticed while testing #14851.

Before:

before

After:

after

I'm not really confident that I fixed this the right way. I'm unclear to me whether the margin between the text and icon is supposed to be 4px per IconButton:

Or if it's supposed to be 5px per MenuItem:

I could really use some of that @jasmussen magic right now! 🙏

Fix menu items in the More menu from shifting horizontally when
selected.
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Aug 2, 2019
@gziolo
Copy link
Member

gziolo commented Aug 2, 2019

I figured out that, it might have regressed in #14843. Although, we were mostly moving styles to different files during that refactoring.

@gziolo gziolo added the Needs Design Feedback Needs general design feedback. label Aug 2, 2019
@karmatosed karmatosed self-requested a review August 2, 2019 11:27
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix to me! Seems good to go for design review as a catch of an issue.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 2, 2019
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karmatosed karmatosed merged commit 60ec8fe into master Aug 9, 2019
@github-actions github-actions bot added this to the Gutenberg 6.3 milestone Aug 9, 2019
@youknowriad youknowriad deleted the fix/shifting-menu-items branch August 10, 2019 09:43
gziolo pushed a commit that referenced this pull request Aug 29, 2019
Fix menu items in the More menu from shifting horizontally when
selected.
gziolo pushed a commit that referenced this pull request Aug 29, 2019
Fix menu items in the More menu from shifting horizontally when
selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants