-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropdownMenu: Fix shifting menu items #16871
Conversation
Fix menu items in the More menu from shifting horizontally when selected.
I figured out that, it might have regressed in #14843. Although, we were mostly moving styles to different files during that refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix to me! Seems good to go for design review as a catch of an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix menu items in the More menu from shifting horizontally when selected.
Fix menu items in the More menu from shifting horizontally when selected.
Fix menu items in the More menu from shifting horizontally when selected. This was noticed while testing #14851.
Before:
After:
I'm not really confident that I fixed this the right way. I'm unclear to me whether the margin between the text and icon is supposed to be
4px
perIconButton
:gutenberg/packages/components/src/icon-button/style.scss
Line 25 in 5b01c97
Or if it's supposed to be
5px
perMenuItem
:gutenberg/packages/components/src/menu-item/style.scss
Line 13 in 5b01c97
I could really use some of that @jasmussen magic right now! 🙏