Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin from sandbox iframe to fix size calculation #1688

Merged
merged 6 commits into from
Jul 12, 2017
Merged

Remove margin from sandbox iframe to fix size calculation #1688

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8074a41
Use body.scrollWidth/scrollHeight instead of offsetWidth/Height to ac…
westonruter Jul 4, 2017
cf67b68
Use bounding client rect and computed margin styles instead of body o…
westonruter Jul 11, 2017
0b21a93
Populate sandbox width and height via CSS to honor floating point dim…
westonruter Jul 11, 2017
2f7f4cc
Use window.parent instead of window.top for sending resize messages
westonruter Jul 11, 2017
f156566
Use iframe width/height attributes instead of style props
westonruter Jul 12, 2017
a394e9a
Set margin:0 on sandbox body; remove margin computing
westonruter Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/sandbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ export default class Sandbox extends wp.element.Component {
function sendResize() {
window.top.postMessage( {
action: 'resize',
width: document.body.offsetWidth,
height: document.body.offsetHeight
width: document.body.scrollWidth,
height: document.body.scrollHeight
}, '*' );
}

Expand Down