Try moving the Modal close button over to the right #16883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the modal close button is in right-aligned to the modal content. But because the button has no border by default, the
x
icon button appears misaligned:When hovering over the button, the borders make the intended alignment more clear:
This PR tries shifting the button over to the right by
8px
to offset the button padding. This properly aligns thex
icon with the right side of the content below it:On hover, the borders appear, and the intentional misalignment becomes clear, but I don't think this is much of an issue. I'd rather that this appeared misaligned in the hover state than in its default state.