Fully disable animation style if enableAnimations is false. #16893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Aug 3, 2019
| let animationStyle = useMovingAnimation( wrapper, isSelected || isPartOfMultiSelection, enableAnimation, animateOnChange ); | ||
|
|
||
| // Dismiss animation style if animations are disabled. | ||
| animationStyle = enableAnimation ? animationStyle : {}; |
There was a problem hiding this comment.
Why don't we do that in the hook itself?
youknowriad
approved these changes
Aug 5, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useMovingAnimationacceptsenableAnimationas param, however, the animation styling is applied eventually to the block wrapper even ifenableAnimationis set tofalse. WithenableAnimationset tofalse,transformis set toundefined, alsotransformOriginis always set.This can potentially override existing
transformcoming fromwrapperProps.stylevia a filter for example.How has this been tested?
Functional testing making sure that the block animations remain as they are by default.
Also tested that when setting
enableAnimationstofalsethe animation related styles are not applied.Checklist: