ESLint plugin: Enable wp
global by default in the recommended
config
#16904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PR where I encountered this issue: WordPress/gutenberg-examples#83.
It's perfectly fine to use
wp
globals when developing plugins as presented below:However, the recommended ESLing config considers this as an error so the only way to make it happy is to silence it. This PR tries to fix this issue which is extremely inconvenient for those using
@wordpress/scripts
with the default configuration.In Gutenberg, it's still something that we want to avoid, so I updated the local config accordingly.
How has this been tested?
npm run lint-js
should error whenwp
global is used in Gutenberg.You can add
const { registerBlockType } = wp.blocks;
anywhere in the source code to validate it.Checklist: