Chore: Upgrade ESLint to the latest version (6.1.0) #16921
Conversation
gziolo
added
[Type] Build Tooling
gziolo
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta,
nerrad,
oandregal,
ntwb,
Soean,
talldan and
youknowriad
as code owners
| [ matcherName ]: createToBeCalledMatcher( `.${ matcherName }`, methodName ), | ||
| [ matcherNameWith ]: createToBeCalledWithMatcher( `.${ matcherNameWith }`, methodName ), | ||
| [ matcherName ]: createToHaveBeenCalledMatcher( `.${ matcherName }`, methodName ), | ||
| [ matcherNameWith ]: createToHaveBeenCalledWith( `.${ matcherNameWith }`, methodName ), | ||
| }; | ||
| }, {} ) | ||
| ); |
There was a problem hiding this comment.
Should the changes here for jest-console be added to the changelog?
There was a problem hiding this comment.
It was part of rename operation and I figured out at the end that it's an internal change. I kept it only for consistency :)
|
@gziolo Regarding |
That would be great, feel free to apply all necessary changes 👍 It's probably how it should work now since they introduced |
|
Can someone help me fix the botched |
It should be fixed now. @swissspidy, all your changes applied to PR look great. Thanks a lot. It didn't occur to me that the issue can be fixed with |
gziolo
force-pushed
the
update/eslint-packages
branch
from
f914fd7
to
729e27a
Compare
|
I rebased PR with |
gziolo
force-pushed
the
update/eslint-packages
branch
from
f691666
to
6462488
Compare
gziolo
force-pushed
the
update/eslint-packages
branch
from
6462488
to
bb31814
Compare
* Chore: Upgrade ESLint to the latest version (6.1.0) * Refactor tests to use native describe.each functionality * Enable jest/valid-describe rule again * Use describe.each in more places * Write describe name on one line * Disable jest/valid-describe individually for special cases * Fix typo * Remove unused import * Remove unnecessary nested describe * Run npm install * Chore: Fix package-lock.json file * Fix failing e2e tests for navigable toolbar * Fix JSDoc rule in ESLint plugin
* Chore: Upgrade ESLint to the latest version (6.1.0) * Refactor tests to use native describe.each functionality * Enable jest/valid-describe rule again * Use describe.each in more places * Write describe name on one line * Disable jest/valid-describe individually for special cases * Fix typo * Remove unused import * Remove unnecessary nested describe * Run npm install * Chore: Fix package-lock.json file * Fix failing e2e tests for navigable toolbar * Fix JSDoc rule in ESLint plugin
Description
This PR updates ESLInt to the latest version:
6.1.0. This is a major version bump.In addition, it updates the following packages which are related to ESLint:
babel-eslint: "^10.0.2",eslint-plugin-jsx-a11y: "^6.2.3"eslint-plugin-react: "^7.14.3" (minor version bump)eslint-plugin-react-hooks: "^1.6.1"There was also this major version upgrade:
eslint-plugin-jest: "22.14.1"I had to disable
jest/valid-describerule because we often create dynamicdescribecalls and this rule doesn't like it. Well, it's not flexible enough in my opinion.How has this been tested?
npm run lint-jsnpm run test-unit