Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: Fix intermittent test failure #16952

Merged
merged 2 commits into from
Aug 7, 2019
Merged

RichText: Fix intermittent test failure #16952

merged 2 commits into from
Aug 7, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Aug 7, 2019

Description

After #16875, this fixes one of the new e2e tests that sometimes fails.

The problem is that we don't wait for the next animation frame:

this.rafId = window.requestAnimationFrame( this.onSelectionChange );

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix
Copy link
Member Author

ellatrix commented Aug 7, 2019

Going to merge this as it's just a test change without any other code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants