Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Run npm audit fix to fix vulnerabilities #16963

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Chore: Run npm audit fix to fix vulnerabilities #16963

merged 1 commit into from
Aug 8, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Aug 8, 2019

Description

I executed npm audit fix on master branch to fix reported vulnerabilities:

added 492 packages from 231 contributors, removed 71 packages and updated 177 packages in 31.751s
fixed 35 of 35 vulnerabilities in 1977114 scanned packages

With that when I run npm install I no longer see reported vulnerabilities:

audited 1977114 packages in 14.412s
found 0 vulnerabilities

@gziolo gziolo added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 8, 2019
@gziolo gziolo self-assigned this Aug 8, 2019
@gziolo gziolo requested review from swissspidy, ntwb and a team August 8, 2019 10:52
ntwb
ntwb approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 4 changes to the lock file!Awesome, wish these PRs were always this easy to review 💥

@ntwb ntwb merged commit 67b2328 into master Aug 8, 2019
@ntwb ntwb deleted the update/run-npm-audit-fix branch August 8, 2019 11:51
@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
@gziolo
Chore: Run npm audit fix to fix vulnerabilities (#16963)
b2b34c2
gziolo added a commit that referenced this pull request Aug 29, 2019
@gziolo
Chore: Run npm audit fix to fix vulnerabilities (#16963)
e1e924c
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@gziolo gziolo

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@gziolo @ntwb @youknowriad